[prometheus-blackbox-exporter] Fix http_2xx defaults #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennybaa
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
dennybaa
changed the title
rsotnychenko
previously approved these changes
Sep 16, 2020
|
@dennybaa thanks for the contribution! Looks like you need to signoff your commits for DCO check to pass. See https://github.com/prometheus-community/helm-charts/pull/101/checks?check_run_id=1123037749 However I'm not sure what's wrong with Lint Code Base, maybe @prometheus-community/helm-charts-admins could help here? |
|
Looks related to markdown linting at #19 Weird, it has not been updated for more than 2 weeks: https://github.com/prometheus-community/helm-charts/commits/main/.github/workflows/linter.yml |
Signed-off-by: Denis Baryshev <dennybaa@gmail.com>
monotek
approved these changes
Sep 18, 2020
fktkrt
pushed a commit
to fktkrt/helm-charts-1
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Denis Baryshev <dennybaa@gmail.com> Signed-off-by: fktkrt <fktkrt@gmail.com>
monotek
pushed a commit
to monotek/prometheus-helm-charts
that referenced
this pull request
Oct 7, 2020
Signed-off-by: Denis Baryshev <dennybaa@gmail.com> Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.