Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Make config installation dir configurable #173

Merged
merged 3 commits into from
Jul 29, 2023
Merged

feature: Make config installation dir configurable #173

merged 3 commits into from
Jul 29, 2023

Conversation

tvenieris
Copy link
Contributor

No description provided.

@tvenieris
feature: Make config installation dir configurable
2b04207 
Signed-off-by: Thomas Venieris <thomas.venieris@gmail.com>
SuperQ
SuperQ requested changes Jul 29, 2023
View reviewed changes
roles/blackbox_exporter/defaults/main.yml Outdated Show resolved Hide resolved
@SuperQ
Copy link
Contributor

SuperQ commented Jul 29, 2023

This also needs to update the meta/argument_specs.yml in order to update the auto-generated role docs.

@tvenieris
fix: blackbox_exporter_config_dir consistent
d446cdd 
- Made blackbox_exporter_config_dir parameter consistent with other
  collection roles
- Added new parameter to meta/argument_specs.yml

Signed-off-by: Thomas Venieris <thomas.venieris@gmail.com>
@github-actions github-actions bot added enhancement New feature or request roles/mysqld_exporter and removed enhancement New feature or request labels Jul 29, 2023
@tvenieris
Merge branch 'main' into blackbox_exporter_config_dir_configurable
5aa1e92 
Signed-off-by: Thomas Venieris <thomas.venieris@gmail.com>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@603aa0c). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main      #173   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         5           
  Lines           ?       102           
  Branches        ?         8           
========================================
  Hits            ?       102           
  Misses          ?         0           
  Partials        ?         0
Flag Coverage Δ
integration 100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@tvenieris tvenieris requested a review from SuperQ July 29, 2023 13:47
SuperQ
SuperQ approved these changes Jul 29, 2023
View reviewed changes
roles/blackbox_exporter/defaults/main.yml
Comment on lines +72 to +73
# Where to put the blackbox_exporter.yml main configuration file
blackbox_exporter_config_dir: /etc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh, we should probably fix this to match the other roles.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup issue: #178

@SuperQ SuperQ merged commit 791b9b1 into prometheus-community:main Jul 29, 2023
@tvenieris tvenieris deleted the blackbox_exporter_config_dir_configurable branch July 29, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request roles/blackbox_exporter roles/mysqld_exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvenieris @SuperQ @codecov-commenter