Skip to content

Commit

Permalink
fix: Don't reload services when restarting
Browse files Browse the repository at this point in the history
Avoid triggering a reload of various role services when a restart is
needed. This avoids the race between restart and reload.

Signed-off-by: SuperQ <superq@gmail.com>
  • Loading branch information
SuperQ committed Jan 29, 2024
1 parent 5423211 commit b38c32d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions roles/alertmanager/handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
daemon_reload: true
name: alertmanager
state: restarted
register: alertmanager_restarted

- name: Reload alertmanager
listen: "reload alertmanager"
become: true
ansible.builtin.systemd:
name: alertmanager
state: reloaded
when: alertmanager_restarted is not defined
2 changes: 2 additions & 0 deletions roles/blackbox_exporter/handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
daemon_reload: true
name: blackbox_exporter
state: restarted
register: blackbox_exporter_restarted

- name: Reload blackbox_exporter
listen: "reload blackbox_exporter"
become: true
ansible.builtin.systemd:
name: blackbox_exporter
state: reloaded
when: blackbox_exporter_restarted is not defined
2 changes: 2 additions & 0 deletions roles/prometheus/handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
daemon_reload: true
name: prometheus
state: restarted
register: prometheus_restarted

- name: Reload prometheus
listen: "reload prometheus"
become: true
ansible.builtin.systemd:
name: prometheus
state: reloaded
when: prometheus_restarted is not defined
2 changes: 2 additions & 0 deletions roles/snmp_exporter/handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
daemon_reload: true
name: snmp_exporter
state: reloaded
register: snmp_exporter_restarted

- name: Restart snmp_exporter
listen: "restart snmp_exporter"
Expand All @@ -14,3 +15,4 @@
daemon_reload: true
name: snmp_exporter
state: restarted
when: snmp_exporter_restarted is not defined

0 comments on commit b38c32d

Please sign in to comment.