JsonProducer should check for errors #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fritz-gerneth can you review please? |
| $this->exchange->publish(json_encode($message), $routingKey, $flags, $attributes); | ||
| try { | ||
| $message = json_encode($message); | ||
| } catch (\Throwable $e) { |
There was a problem hiding this comment.
To my knowledge json_encode will never throw an exception (SO, PHP Doc Comment. )
There was a problem hiding this comment.
json_encode does not throw an exception, but an object implementing JsonSerializable can throw an exception in its jsonSerialize method.
| $producer = new JsonProducer($exchange->reveal()); | ||
|
|
||
| $message = new class() implements \JsonSerializable { | ||
| public function jsonSerialize() |
There was a problem hiding this comment.
As suggested by php PHP Doc's comments this will be catched and consumed by json_encode. Not saying the test is wrong, just think they both get handled by the json_last_error condition.
There was a problem hiding this comment.
No it won't, the exception in jsonSerialize method is thrown instead. I tested this already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #46