Skip to content

fix exchange binding / unbinding for php-amqplib #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2017
Merged

fix exchange binding / unbinding for php-amqplib #38

merged 3 commits into from
Jun 11, 2017

Conversation

prolic
Copy link
Owner

@prolic prolic commented Jun 4, 2017

No description provided.

@prolic prolic self-assigned this Jun 4, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 90.892% when pulling 5da3e5c on php-amqplib into 8b2eac8 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 90.892% when pulling a00e90d on php-amqplib into 8b2eac8 on master.

yethee
yethee reviewed Jun 6, 2017
View reviewed changes
README.md Outdated
@@ -17,7 +17,8 @@ The JSON-RPC part implements [JSON-RPC 2.0 Specification](http://www.jsonrpc.org

Current supported drivers are: [php-amqp](https://github.com/pdezwart/php-amqp) and [PhpAmqpLib](https://github.com/php-amqplib/php-amqplib).

php-amqp needs at least to be v1.8.0beta1.
php-amqp needs at least to be v1.9.0
php-amqplib needs at least to e v2.7.0-rc1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems, character b is missing.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, updated.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 90.892% when pulling ed28393 on php-amqplib into 8b2eac8 on master.

@prolic prolic merged commit 8ee0e99 into master Jun 11, 2017
@prolic prolic deleted the php-amqplib branch June 11, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yethee yethee yethee left review comments

Assignees

@prolic prolic

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prolic @coveralls @yethee