(bug) Correctly read resources contained in EventReports #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, code was getting resources contained in the EventReports and using strings.Split to separate resources, which fails when a resource itself contains the `---` separator. A common example is a ConfigMap holding a certificate, which includes `-----BEGIN CERTIFICATE-----` within its data. The fix replaces strings.Split with __deployer.CustomSplit__, a function designed to properly handle these cases by parsing the YAML structure without confusing internal content with resource delimiters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, code was getting resources contained in the EventReports and using strings.Split to separate resources, which fails when a resource itself contains the
---separator.A common example is a ConfigMap holding a certificate, which includes
-----BEGIN CERTIFICATE-----within its data.The fix replaces strings.Split with deployer.CustomSplit, a function designed to properly handle these cases by parsing the YAML structure without confusing internal content with resource delimiters.
Fixes #389