(bug) Profile selection was broken #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting the "Profiles" we see all profiles organized by tier. Here we have both ClusterProfile (which are cluster wide resources) and Profiles (which are namespaced resources). While selecting a ClusterProfile was correctly loading a page showing the ClusterProfile dependencies and dependents, selecting a Profile was not loading. The issue is a Profile is identified by namespace and name (while a ClusterProfile is identified just by name). This PR fixes that (verified it locally). This PR also makes sure we consistently use "profiles" when generically referencing to both ClusterProfile and Profile.
Member
Author
|
Contributor
|
Awesome Work |
Safouene1
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting the "Profiles" we see all profiles organized by tier. Here we have both ClusterProfile (which are cluster wide resources) and Profiles (which are namespaced resources).
While selecting a ClusterProfile was correctly loading a page showing the ClusterProfile dependencies and dependents, selecting a Profile was not loading.
The issue is a Profile is identified by namespace and name (while a ClusterProfile is identified just by name).
This PR fixes that (verified it locally).
This PR also makes sure we consistently use "profiles" when generically referencing to both ClusterProfile and Profile.