issue-277 few null checks to avoid crash when node went under bottom … #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieLazarLDAPPS
commented
Aug 7, 2019
src/DiagramEngine.ts
Outdated
| } | ||
|
|
||
| getNodeElement(node: NodeModel): Element { | ||
| if (!this.canvas) { |
There was a problem hiding this comment.
When the node is under the bottom of the screen canvas is null.
|
Are you able to port these fixes to the new 6.0 version? |
|
Yeap I will |
DanieLazarLDAPPS
force-pushed
the
bugfix/#277-smart-route-canvas-null-check
branch
from
a978a9a to
264c74e
Compare
|
Hi @dylanvorster, well I migrated fixes to 6 version but unfortunately, it won't help. Please check following gif how to reproduce this error. The problem is in PathFinderLinkWidget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run prettyWhat?
Issue with smart routing
Why?
Because of this issue
#277
How?
I just went thru errors reported by the console and I added few null checks and it fixed that issue. But I have no idea if there will be some deeper dependency so please check it out. Thank you
Feel-Good "programming lol" image:
(Add your own one below :])