Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: explicitly include namespace in created resources #9711

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Oct 7, 2024

Fixes #9620. Obsoletes #9621.

@@ -20,7 +20,8 @@
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
name: {{ template "nessie.fullname" . }}
name: {{ include "nessie.fullname" . }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to align with other occurrences of this template inclusion. (In this context, using template or include yields the same result.)

@adutra adutra merged commit f077038 into projectnessie:main Oct 7, 2024
16 checks passed
@adutra adutra deleted the helm-metadata-namespace branch October 7, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Helm chart does not specify metadata.namespace which breaks CD tool ArgoCD
3 participants