Skip to content

Removing Deprecations Warnings from agent_portrayal and propertylayer_portrayal until next release. #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

Sahil-Chhoker
Copy link
Collaborator

Summary

Removes Deprecations Warnings from agent_portrayal and propertylayer_portrayal, linked comment.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -0.1% [-1.1%, +0.9%] 🔵 -0.1% [-0.3%, +0.1%]
BoltzmannWealth large 🔵 -0.1% [-0.7%, +0.4%] 🔵 -0.4% [-2.2%, +1.5%]
Schelling small 🔵 -0.1% [-0.2%, +0.0%] 🔵 -0.4% [-0.7%, -0.2%]
Schelling large 🔵 -0.3% [-1.0%, +0.5%] 🔵 -2.8% [-3.9%, -1.8%]
WolfSheep small 🔵 +0.3% [-0.0%, +0.6%] 🔵 -1.0% [-1.1%, -0.8%]
WolfSheep large 🔵 +0.4% [-0.0%, +0.9%] 🔵 -0.4% [-1.4%, +0.5%]
BoidFlockers small 🔵 -0.5% [-1.2%, +0.4%] 🔵 +1.3% [+1.1%, +1.5%]
BoidFlockers large 🔵 -0.6% [-0.9%, -0.4%] 🔵 +0.2% [-0.1%, +0.5%]

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

We can revert this commit after a few releases.

@EwoutH
Copy link
Member

EwoutH commented May 27, 2025

Wait, actually, I think you can just change it to a PendingDeprecationWarning instead of removing it.

@Sahil-Chhoker
Copy link
Collaborator Author

I didn't know such thing existed, makes more sense in this case.

@EwoutH EwoutH merged commit ed91ba6 into projectmesa:main May 27, 2025
12 checks passed
@EwoutH
Copy link
Member

EwoutH commented May 27, 2025

It's quite a niche thing I happened to know by accident.

Thanks!

@EwoutH EwoutH added the maintenance Release notes label label May 27, 2025
Holzhauer pushed a commit to UniK-INES/mesa that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants