Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 1.16.22: @EqualsAndHashCode includes transient fields by default #1773

Closed
emlun opened this issue Jul 10, 2018 · 3 comments
Closed

Comments

@emlun
Copy link
Contributor

emlun commented Jul 10, 2018

With this code:

@EqualsAndHashCode
public class BugExample {

    int a;
    transient int b;

    public BugExample(int a, int b) {
        this.a = a;
        this.b = b;
    }

}

the field b in fact does make a difference for .equals. The regression was introduced in version 1.16.22; 1.16.20 works as documented.

Minimal example with tests exposing the issue: https://github.com/emlun/lombok-1.16.22-regression

Probably related to #1772.

@Maaartinus
Copy link
Contributor

I'd bet this has been fixed in 1.18, just can't see it in the changelog.

@emlun
Copy link
Contributor Author

emlun commented Jul 10, 2018

Sorry, yep, it's fixed in f241ef8 on master. Also duplicate of #1724.

@emlun emlun closed this as completed Jul 10, 2018
@emlun
Copy link
Contributor Author

emlun commented Jul 10, 2018

I mean it's not fixed in the 1.18.0 release, but I guess the fix will be included in the next release.

emlun added a commit to Yubico/java-webauthn-server that referenced this issue Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants