Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log event IDs #342

Closed
wants to merge 2 commits into from
Closed

Log event IDs #342

wants to merge 2 commits into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Nov 4, 2024

No description provided.

@Shatur Shatur requested a review from UkoeHB November 4, 2024 19:19
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (e27d05c) to head (d30cf02).

Files with missing lines Patch % Lines
src/core/event_registry/client_event.rs 33.33% 2 Missing ⚠️
src/core/event_registry/server_event.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   90.05%   89.89%   -0.16%     
==========================================
  Files          37       37              
  Lines        2362     2366       +4     
==========================================
  Hits         2127     2127              
- Misses        235      239       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur
Copy link
Contributor Author

Shatur commented Nov 4, 2024

Ah, not necessary, it's logged later.

@Shatur Shatur closed this Nov 4, 2024
@Shatur Shatur deleted the log_event_ids branch November 4, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant