Client-server-features #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to move a few modules into core since they used on both.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.14.0-rc #298 +/- ##
=============================================
- Coverage 90.96% 90.95% -0.01%
=============================================
Files 37 37
Lines 2202 2200 -2
=============================================
- Hits 2003 2001 -2
Misses 199 199 ☔ View full report in Codecov by Sentry. |
UkoeHB
approved these changes
Jun 27, 2024
| @@ -20,30 +20,31 @@ fn serialize_missing_component() { | |||
| let mut app = App::new(); | |||
| app.add_plugins((MinimalPlugins, RepliconPlugins)); | |||
|
|
|||
| let tick = RepliconTick::default(); | |||
There was a problem hiding this comment.
Are there any tests for the case when tick is not default?
There was a problem hiding this comment.
No, but it's just to pass it to the context, we don't use it for the logic.
Shatur
added a commit
that referenced
this pull request
Jul 4, 2024
* Update to 0.14.0-rc.2 * Temporary disable CI for bevy_replicon_renet * Minor stylistic changes Just a few spaces and an intermediate veriable to make the code look a little bit nicer. * Bump version to 0.27.0-rc.1 * Remove bevy_replicon_renet from workspace * Bump version to 0.27.0-rc.2 * Undo changes in bevy_replicon_renet [skip ci] * Rework events organization - Swap `receive` system between ServerEventsPlugin and `ClientEventsPlugin` to properly separate what what runs on client or server. - Move `ServerEventsPlugin::reset` logic inside `ClientEventsPlugin::reset` because this logic runs on client. - Move `server::events::event_data` module to `core::event_registry::server_event`. - Move `client::events::event_data` module to `core::event_registry::client_event`. No functional changes, except `ServerEventsPlugin` and `ClientEventsPlugin` can be disabled on client-only and server-only apps respectively. Closes #276. * Do not divide values per seconds by the number of messages * Update changelog [skip ci] * Put `ClientDiagnosticsPlugin` under `diagnostics` feature (#295) * Put `scene` module under `scene` feature (enabled by default) * Put `parent_sync` module under `parent_sync` feature * Client-server-features (#298) * Use GitHub's warning about semver compatibility https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts * Document features better I took inspiration from Bevy. * Update src/lib.rs * Move `bevy_replicon_renet` to a dedicated repository * Bump version to 0.27.0-rc.3 * Fix copy-paste * Speedup removals caching The necessary method was provided in 0.14. * Remove mentions of the RC Without it it will be quite hard to read the changelog (users will have to check the changes from RC) or I will need to copy all changes from RC for the upcoming 0.27.0. I also removed it from the compatibility table as suggested by @UkoeHB. I also don't think that they will be useful... Keeping them will make the table harder to read. Another option would be to keep them, but put under a spoiler. --------- Co-authored-by: UkoeHB <37489173+UkoeHB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to move a few modules into core since they used on both.
Advises about the organization are very welcome!