Refactoring in preparation for manual packet fragmentation #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 89.68% 91.09% +1.40%
==========================================
Files 14 15 +1
Lines 892 898 +6
==========================================
+ Hits 800 818 +18
+ Misses 92 80 -12 ☔ View full report in Codecov by Sentry. |
Shatur
force-pushed
the
entity-hasher
branch
from
979c902 to
3793d01
Compare
And move it to `scene` module since it's not directly related to server and isn't used inside it.
Shatur
changed the title
EntityHashMap instead of all HashMap with entities as keys
Shatur
force-pushed
the
entity-hasher
branch
from
dd37277 to
291ddaa
Compare
- Improve docs. - Use names that not coupled with replication message structure. - Group functions differently for clarity. - Use replication channel constant directly. - Move entity serialization into a free function to reuse it later.
Shatur
force-pushed
the
entity-hasher
branch
from
ae730d4 to
fcdd588
Compare
UkoeHB
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityHashMapinstead ofHashMapwith entities as keys. For details see Use EntityHashMap<Entity, T> for render world entity storage for better performance bevyengine/bevy#9903.replicate_into_sceneintoreplicate_intoand move it toscenemodule.