Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1434998 - Allow for REPLACE values to be Patterns or PatternElements #41

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Bug 1434998 - Allow for REPLACE values to be Patterns or PatternElements #41

merged 2 commits into from
Feb 2, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Feb 2, 2018

@stasm stasm requested a review from zbraniecki February 2, 2018 17:08
@stasm
Copy link
Contributor Author

stasm commented Feb 2, 2018 •
edited
Loading

@zbraniecki This should help with the migration in bug 1424682. The first commit makes it possible to use Patterns and PatternElements as replacement values in REPLACE. Take a look at the changes in ast.py and the tests. The second commit is a refactor to make the code easier to understand and more Pythonic.

zbraniecki
zbraniecki approved these changes Feb 2, 2018
View reviewed changes
tests/migrate/test_replace.py
{
'#1': FTL.Placeable(
EXTERNAL_ARGUMENT('user')
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work also with just EXTERNAL_ARGUMENT('user')?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all other tests in this file are written that way :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works because of https://github.com/projectfluent/python-fluent/pull/41/files/e731e8dfbd62cdc6762a5906473aff0925af1e7d#diff-f684603bb97b0b183acc54fecb78696fR176

@stasm stasm merged commit 3d791a7 into projectfluent:master Feb 2, 2018
@stasm stasm deleted the replace-pattern branch February 2, 2018 18:28
@stasm stasm added this to the python-fluent 0.6.1 milestone Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
python-fluent 0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @zbraniecki