Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1435181 - Warn about unknown FTL entities in transforms #40

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Bug 1435181 - Warn about unknown FTL entities in transforms #40

merged 1 commit into from
Feb 2, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Feb 2, 2018

@stasm stasm requested a review from flodolo February 2, 2018 13:38
@stasm stasm force-pushed the warn-missing-id-in-reference branch from f68f092 to e3dfb00 Compare February 2, 2018 13:48
@stasm stasm force-pushed the warn-missing-id-in-reference branch from e3dfb00 to d1bc398 Compare February 2, 2018 13:53
flodolo
flodolo approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally 👍

@stasm stasm merged commit cb318cb into projectfluent:master Feb 2, 2018
@stasm stasm deleted the warn-missing-id-in-reference branch February 2, 2018 13:59
@stasm stasm added this to the python-fluent 0.6.1 milestone Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
python-fluent 0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @flodolo