Bug 1420225 - Read legacy files when scanning for Sources in transforms #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbraniecki
approved these changes
Nov 27, 2017
Pike
approved these changes
Nov 29, 2017
fluent/migrate/context.py
Outdated
| @@ -139,7 +139,7 @@ def maybe_add_localization(self, path): | |||
| else: | |||
| self.localization_resources[path] = collection | |||
|
|
|||
| def add_transforms(self, path, reference, transforms): | |||
| def add_transforms(self, target, reference, transforms): | |||
| """Define transforms for path using reference as template. | |||
There was a problem hiding this comment.
Want to adjust the comment to change from path to target, too?
There was a problem hiding this comment.
Sure, I considered it but thought that the current comment was still OK. Happy to change it.
There was a problem hiding this comment.
I think an udpate would be good, as right now, for path isn't good English, if path isn't the argument.
There was a problem hiding this comment.
Yeah, agreed. I updated the comment and also added two sentences about what those paths are supposed to be relative to.
stasm
force-pushed
the
1420225-auto-add-legacy
branch
from
abbf7bd
to
5e32cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1420225
This is a simple change which makes it unnecessary to use
maybe_add_localization—at all.