Bug 1321290 - Migrate HTML entities to Unicode characters #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
force-pushed
the
1321290-migrate-html-entities
branch
from
5cb5722 to
e0927d4
Compare
stasm
force-pushed
the
1321290-migrate-html-entities
branch
from
e0927d4 to
716c292
Compare
|
CI fails because the compare-locales patch in bug 1321290 needs to land first. |
Pike
reviewed
Nov 23, 2017
tests/migrate/test_source.py
Outdated
| ''') | ||
|
|
||
| def test_simple_text(self): | ||
| source = Source('test.properties', 'foo') |
There was a problem hiding this comment.
test.dtd should be the source file. Probably irrelevant, but still
tests/migrate/test_source.py
Outdated
| self.strings = parse(DTDParser, ''' | ||
| <!ENTITY foo "Foo"> | ||
|
|
||
| <!ENTITY unicodeEscape "FOO\\u0020BAR"> |
There was a problem hiding this comment.
I'd like this to be actually tested.
stasm
force-pushed
the
1321290-migrate-html-entities
branch
from
f19c1fa to
1afd805
Compare
Pike
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1321290