Bug 1366298 - Skip SelectExpression in PLURALS for one plural category #27
Conversation
|
|
||
| # A special case for languages with one plural category. We don't need | ||
| # to insert a SelectExpression at all for them. | ||
| if len(keys) == len(variants) == 1: |
There was a problem hiding this comment.
The special case is only triggered when both the number of plural categories in CLDR and the number of variants in the legacy translation are 1.
If the legacy translation has more variants we will still insert a SelectExpression: https://github.com/projectfluent/python-fluent/pull/27/files#diff-6d4522d85d5c0eb1cbe1e024d2407986R69
There was a problem hiding this comment.
I think my comment about the test name holds true for most of the file here.
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1415555 with some suggestions on how to evolve the tests here.
tests/migrate/test_plural.py
Outdated
|
|
||
|
|
||
| @unittest.skipUnless(PropertiesParser, 'compare-locales required') | ||
| class TestPluralManyCategoriesWithReplace(MockContext): |
There was a problem hiding this comment.
Can you rename the test? Right now, this is test_plural.TestPluralManyCategoriesWithReplace.test_plural.
One plural is enough, how about TestManyCategories.test_with_replace()?
That said, this test sounds more like a test for the upcoming patch about strictly matching plural forms between toolkit and cldr?
Languages with one plural category can have their translations migrated directly to a single Pattern rather than a SelectExpression with one variant. This will only happen when the number of variants in the legacy translation is also one. This also adds tests for languages with more categories than en-US.
stasm
force-pushed
the
1366298-migrate-plural-tests
branch
from
2f0b34c to
a0cda4c
Compare
https://bugzilla.mozilla.org/show_bug.cgi?id=1366298
Languages with one plural category can have their translations migrated
directly to a single
Patternrather than aSelectExpressionwith onevariant. This will only happen when the number of variants in the
legacy translation is also one.
This also adds tests for languages with more categories than en-US.