Run Structure and Behavior tests in Python 3 #22
Conversation
setup.py
Outdated
| } | ||
| ) | ||
| }, | ||
| install_requires=['six'] |
There was a problem hiding this comment.
Do we actually need this if it's only used for testing?
There was a problem hiding this comment.
You can use tests_require, I think.
tox.ini
Outdated
| @@ -1,11 +1,12 @@ | |||
| [tox] | |||
| envlist = py27, py27-cl, py36 | |||
| envlist = py27, py27-cl, py35 | |||
There was a problem hiding this comment.
I changed this to Python 3.5 because it's the default in Ubuntu 16.04 LTS onwards. The upcoming 17.10 will change to 3.6 but I think we should try to be compatible with the lowest 3.x version possible.
There was a problem hiding this comment.
There doesn't seem to be any good way to install 3.5 on macs.
Also, I don't think we should drop 3.6 completely.
Practically, requiring both will make one platform fail on macs, and the other on linux, and both test on travis. Good enough?
setup.py
Outdated
| } | ||
| ) | ||
| }, | ||
| install_requires=['six'] |
There was a problem hiding this comment.
You can use tests_require, I think.
tox.ini
Outdated
| @@ -1,11 +1,12 @@ | |||
| [tox] | |||
| envlist = py27, py27-cl, py36 | |||
| envlist = py27, py27-cl, py35 | |||
There was a problem hiding this comment.
There doesn't seem to be any good way to install 3.5 on macs.
Also, I don't think we should drop 3.6 completely.
Practically, requiring both will make one platform fail on macs, and the other on linux, and both test on travis. Good enough?
|
Looking at https://travis-ci.org/projectfluent/python-fluent/builds/286440149, Travis ran 2.7, 2.7 with compare-locales, 3.5 and 3.7 (as |
I think we need to add 3.6 to .travis.yml. It's weird that the 3.5 python picks up the 3.6 test env in tox-travis. |
|
Yup, that fixed it, thanks. https://travis-ci.org/projectfluent/python-fluent/builds/286449582 |
Fix #21.