Skip to content

Conversation

@Pike
Copy link
Contributor

@Pike Pike commented May 18, 2020

Our READMEs on the fluent packages are lacking.

Also convert to restructuredText to align with rest of docs.

@Pike Pike force-pushed the readmess branch 2 times, most recently from 21cafbf to 78d3124 Compare May 18, 2020 16:44
Our READMEs on the fluent packages are lacking. Create some,
and use them in setup.py to add better content on pypi.

Also convert to restructuredText to align with rest of docs.

The documentation for fluent.pygments is really just to demo
the highlighting.
@Pike Pike marked this pull request as ready for review May 20, 2020 11:33
@Pike Pike requested a review from stasm May 20, 2020 11:33
===============================

Use `Fluent`_ to localize your Python application. It comes with a ``Localization``
class to use, based on an implementation of bundle. It uses the parser from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way it's used here, bundle is a bit enigmatic. Perhaps mention FluentBundle, i.e. the class?

(I realize this is copied from the current README; if you'd prefer to fix this later rather than in a drive-by, that's fine with me.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this in both READMEs.

``fluent.syntax`` |fluent.syntax|
---------------------------------

Process, analyze, and transform `Fluent`_ files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps explicitly mention parsing and serializing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or: Read, write, and transform...?

@Pike Pike merged commit d421ce1 into projectfluent:master May 20, 2020
@Pike Pike deleted the readmess branch May 20, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants