Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from gitbook to mdbook #363

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Switch from gitbook to mdbook #363

merged 4 commits into from
Jan 22, 2024

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented Jan 11, 2024

Fixes #256

@flodolo flodolo requested a review from eemeli January 11, 2024 19:40
@flodolo flodolo self-assigned this Jan 11, 2024
@flodolo
Copy link
Contributor Author

flodolo commented Jan 12, 2024

The current rendering is available here: https://test.flod.org/tmp_guide/

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.nojekyll Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this added? AFAIK, there are no files or directories starting with an underscore in the mdbook results.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had other errors (again, a long time time ago). Since we don't use Jekyll, I tend to leave it there and disable it.

package.json Outdated
@@ -40,8 +40,7 @@
"eslint": "^6.7.2",
"@fluent/bundle": "^0.14.0",
"@fluent/syntax": "^0.14.0",
"gh-pages": "^2.1.1",
"gitbook-cli": "^2.3.2",
"gh-pages": "^6.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably drop this and the npm run deploy script, if/as we're going to presume that the action will take care of that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this and the deploy action, but I didn't run any npm command (as said, I'd prefer for someone who understands JS to do that)

Copy link
Contributor Author

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test the changes you suggested on another repo

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.nojekyll Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had other errors (again, a long time time ago). Since we don't use Jekyll, I tend to leave it there and disable it.

@flodolo flodolo merged commit 4ea5c7a into master Jan 22, 2024
1 check passed
@flodolo flodolo deleted the mdbook branch January 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from gitbook
2 participants