Include the line end in spans of Messages and Terms #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the change made to Comments except here it doesn't
affect the values, just the spans.
The EBNF defines Message and Term as:
Message ::= Comment? Identifier inline_space? "=" inline_space? ((Pattern Attribute*) | (Attribute+)) line_end
Term ::= Comment? TermIdentifier inline_space? "=" inline_space? Value Attribute* line_end
Pike
approved these changes
Jul 17, 2018
stasm
added a commit
to projectfluent/python-fluent
that referenced
this pull request
Jul 17, 2018
Port of projectfluent/fluent.js#258 This is similar to the change made to Comments except here it doesn't affect the values, just the spans. The EBNF defines Message and Term as: Message ::= Comment? Identifier inline_space? "=" inline_space? ((Pattern Attribute*) | (Attribute+)) line_end Term ::= Comment? TermIdentifier inline_space? "=" inline_space? Value Attribute* line_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the change made to Comments except here it doesn't
affect the values, just the spans.
The EBNF defines Message and Term as: