Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update check and self update option #780

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Add update check and self update option #780

merged 7 commits into from
Mar 15, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Mar 3, 2023 •
edited
Loading

Proposed Changes

  • adds update flags
UPDATE:
   -up, -update                 update subfinder to latest version
   -duc, -disable-update-check  disable automatic subfinder update check

closes #779

@RamanaReddy0M RamanaReddy0M self-assigned this Mar 3, 2023
@RamanaReddy0M RamanaReddy0M changed the title Add update flags (#779) Add update flags Mar 14, 2023
@RamanaReddy0M RamanaReddy0M changed the title Add update flags Add update check and self update option Mar 14, 2023
@RamanaReddy0M
- Add update check and update options (#779)
bd67768 
- use utils repo helper function to update binary
@RamanaReddy0M RamanaReddy0M linked an issue Mar 14, 2023 that may be closed by this pull request
add update flags to subfinder #779
Closed
@RamanaReddy0M RamanaReddy0M requested a review from ehsandeep March 14, 2023 12:20
tarunKoyalwar

This comment was marked as resolved.

Sign in to view

tarunKoyalwar
tarunKoyalwar approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ehsandeep ehsandeep merged commit ff7a546 into dev Mar 15, 2023
@ehsandeep ehsandeep deleted the issue-779-add-update-flags branch March 15, 2023 11:33
@ulises2k
Copy link

image

[updater] failed to fetch latest release of subfinder

@tarunKoyalwar
Copy link
Member

@ulises2k can you share output of subfinder -update -v ?? it will show the exact error that occured

@ulises2k
Copy link

image

@ulises2k
Copy link

image

@ulises2k
Copy link

You are calling tlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add update flags to subfinder
4 participants
@RamanaReddy0M @ulises2k @tarunKoyalwar @ehsandeep