Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making config file recoverable errors non fatal #526

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Making config file recoverable errors non fatal #526

merged 2 commits into from
Mar 31, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Mar 28, 2022 •
edited
Loading

Description

This PR makes the config/provider-config recoverable I/O errors non fatal

Notes

Depends on projectdiscovery/goflags#43

@Mzack9999 Mzack9999 added Status: In Progress This issue is being worked on, and has someone assigned. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Mar 28, 2022
@Mzack9999 Mzack9999 self-assigned this Mar 28, 2022
@Mzack9999 Mzack9999 removed the Status: In Progress This issue is being worked on, and has someone assigned. label Mar 29, 2022
@Mzack9999 Mzack9999 linked an issue Mar 29, 2022 that may be closed by this pull request
[Issue] subfinder 2.5.0 behavior change #518
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 29, 2022
@ehsandeep ehsandeep requested a review from parrasajad March 29, 2022 17:20
@thesamesam thesamesam mentioned this pull request Mar 30, 2022
Merged
@ehsandeep ehsandeep merged commit 64dc230 into dev Mar 31, 2022
@ehsandeep ehsandeep deleted the issue-518-behavior-change branch March 31, 2022 15:17
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 31, 2022
ehsandeep added a commit that referenced this pull request Apr 4, 2022
@thesamesam @ehsandeep
Don't make missing providers-config fatal on first-run (#527)
9a438c5 
* fix readme golang demo for v2.5.0

* Don't make missing providers-config fatal on first-run

It's okay if we fall back to the default config
which is in memory & will get saved out when done
parsing.

This is on top of the work in #526, but a slightly
different issue.

See: #526
Signed-off-by: Sam James <sam@gentoo.org>

Co-authored-by: Sandeep Singh <sandeep@projectdiscovery.io>
Co-authored-by: zhangchengguo <zhangchengguo@360.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parrasajad parrasajad parrasajad approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] subfinder 2.5.0 behavior change
3 participants
@Mzack9999 @ehsandeep @parrasajad