Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source zoomeye subdomain api #477

Merged
merged 6 commits into from
Dec 22, 2021
Merged

Conversation

M09Ic
Copy link
Contributor

@M09Ic M09Ic commented Dec 20, 2021

Use new api(https://api.zoomeye.org/domain/search) instead of zoomeye search.

It can find more subdomains than zoomeye search.this api is free, fast and no limit

Need to get apikey on this page: https://www.zoomeye.org/profile/info

Set "zoomeyekey" in config.yaml:

zoomeyeapi:
    - c659bb1e-0000-00000-0000-c9643450fee7

example:
subfinder -d shein.com -sources [source]

zoomeyeapi
Found 74 subdomains for shein.com in 3 seconds 211 milliseconds

zoomeye
Found 40 subdomains for shein.com in 47 seconds 396 milliseconds

@M09Ic
Copy link
Contributor Author

M09Ic commented Dec 20, 2021

additional:
this commit 341575c

fix zoomeye source(not zoomeyeapi) turn page bug.

test:
-d shein.com -sources zoomeye

Before repair:
Found 40 subdomains for shein.com in 47 seconds 396 milliseconds

After repair:
Found 55 subdomains for shein.com in 1 minute 30 seconds

@M09Ic M09Ic changed the title Add zoomeye subdomain api Add source zoomeye subdomain api Dec 20, 2021
@ehsandeep ehsandeep changed the base branch from master to dev December 21, 2021 09:25
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M09Ic thank you for adding API support, as the API produces better results, do you think we can consider deprecating zoomeye source and replacing the API with it, or do you have any additional value by keeping the old source?

@M09Ic
Copy link
Contributor Author

M09Ic commented Dec 21, 2021

@M09Ic thank you for adding API support, as the API produces better results, do you think we can consider deprecating zoomeye source and replacing the API with it, or do you have any additional value by keeping the old source?

zoomeye and zoomeyeapi have different data sources.

zoomeye fetches subdomains from ip, more like fofa and shodan, but there is a limit of 400 data items for normal user.

zoomeyeapi is querying subdomain data directly from the api, rather than finding subdomains from the ip. And zoomeyeapi has no limit.

So, zoomeye has a different data source than zoomeyeapi, and may have some additional subdomians. I think we can keep the zoomeye source

@ehsandeep ehsandeep requested a review from Mzack9999 December 21, 2021 12:26
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There is only some commented code to remove if possible.

v2/pkg/subscraping/sources/zoomeyeapi/zoomeyeapi.go Outdated Show resolved Hide resolved
@ehsandeep ehsandeep merged commit 37645f4 into projectdiscovery:dev Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants