Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config location #1013

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix config location #1013

merged 2 commits into from
Oct 30, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Oct 11, 2023 •
edited
Loading

Closes #1012.

$ ./subfinder -version
[INF] Current Version: v2.6.4-dev

@dogancanbakir dogancanbakir self-assigned this Oct 11, 2023
@dogancanbakir dogancanbakir linked an issue Oct 11, 2023 that may be closed by this pull request
Issue with loading provider file from new location #1012
Closed
@dogancanbakir dogancanbakir mentioned this pull request Oct 12, 2023
Closed
tarunKoyalwar
tarunKoyalwar approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

minor change - subfinder now prints config directory location when using -version flag . as config location is now distro specific ( we also do this in nuclei)

$ ./subfinder -version                                        
[INF] Current Version: v2.6.4-dev
[INF] Subfinder Config Directory: /Users/tarun/Library/Application Support/subfinder

@ehsandeep ehsandeep merged commit c175790 into dev Oct 30, 2023
@ehsandeep ehsandeep deleted the fix_config_location branch October 30, 2023 16:01
@BrewTestBot BrewTestBot mentioned this pull request Jan 11, 2024
Merged
@chenrui333
Copy link
Contributor

per homebrew 2.6.4 build, I can see the config file for osx build, but I cannot see it for the linux build, is that expected?

runner@fv-az802-515:/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core$ tree /tmp/subfinder-test-20240111-6780-n5odxx
/tmp/subfinder-test-20240111-6780-n5odxx
...

/private/tmp/subfinder-test-20240111-70370-cspnhi
└── Library
    ├── Application Support
    │   └── subfinder
    │       ├── config.yaml
    │       └── provider-config.yaml
...

@chenrui333 chenrui333 mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with loading provider file from new location
4 participants
@dogancanbakir @chenrui333 @ehsandeep @tarunKoyalwar