Skip to content

init ExecutionId in DefaultOptions func #6598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dogancanbakir wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

init ExecutionId in DefaultOptions func #6598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b98417
init exec id
dogancanbakir Nov 10, 2025
6a1451f
remove redundant init
dogancanbakir Nov 10, 2025
ce6070d
remove redundant init
dogancanbakir Nov 21, 2025
683bc04
Merge branch 'dev' into 6594_init_exec_id
dogancanbakir Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/multi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/projectdiscovery/nuclei/v3/pkg/types"
"github.com/projectdiscovery/nuclei/v3/pkg/utils"
"github.com/projectdiscovery/utils/errkit"
"github.com/rs/xid"
)

// unsafeOptions are those nuclei objects/instances/types
Expand Down Expand Up @@ -86,7 +85,6 @@ type ThreadSafeNucleiEngine struct {
// Note: Non-thread-safe methods start with Global prefix
func NewThreadSafeNucleiEngineCtx(ctx context.Context, opts ...NucleiSDKOptions) (*ThreadSafeNucleiEngine, error) {
defaultOptions := types.DefaultOptions()
defaultOptions.ExecutionId = xid.New().String()
// default options
e := &NucleiEngine{
opts: defaultOptions,
Expand Down
2 changes: 0 additions & 2 deletions lib/sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
"github.com/projectdiscovery/ratelimit"
"github.com/projectdiscovery/retryablehttp-go"
"github.com/projectdiscovery/utils/errkit"
"github.com/rs/xid"
)

// NucleiSDKOptions contains options for nuclei SDK
Expand Down Expand Up @@ -319,7 +318,6 @@ func (e *NucleiEngine) Store() *loader.Store {
func NewNucleiEngineCtx(ctx context.Context, options ...NucleiSDKOptions) (*NucleiEngine, error) {
// default options
defaultOptions := types.DefaultOptions()
defaultOptions.ExecutionId = xid.New().String()
e := &NucleiEngine{
opts: defaultOptions,
mode: singleInstance,
Expand Down
2 changes: 2 additions & 0 deletions pkg/types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
fileutil "github.com/projectdiscovery/utils/file"
folderutil "github.com/projectdiscovery/utils/folder"
unitutils "github.com/projectdiscovery/utils/unit"
"github.com/rs/xid"
)

const DefaultTemplateLoadingConcurrency = 50
Expand Down Expand Up @@ -793,6 +794,7 @@ func DefaultOptions() *Options {
MaxHostError: 30,
ResponseReadSize: 10 * unitutils.Mega,
ResponseSaveSize: unitutils.Mega,
ExecutionId: xid.New().String(),
}
}

Expand Down
Loading