Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some workflow templates #3521

Merged
merged 17 commits into from
Jan 12, 2022
Merged

Add some workflow templates #3521

merged 17 commits into from
Jan 12, 2022

Conversation

daffainfo
Copy link
Contributor

Template / PR Information

  • Fixed CVE-2020-XXX / Added CVE-2020-XXX / Updated CVE-2020-XXX
  • References:

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

Additional References:

@DhiyaneshGeek
Copy link
Member

@ehsandeep This does not look good actually , simply creating a workflow template for one one template

i can see last nuclei template release also this happened

image

This way one can increase the total number of counts :(

Could you please have a look at this once

@ehsandeep
Copy link
Member

@DhiyaneshGeek Workflows are just as important as templates because they allow you to run nuclei scans in the most efficient way possible, i.e. by running templates based on the tech stack rather than all templates on unrelated targets. To do this, we need to ensure that all technology is covered in workflows, which we also discussed here.

@daffainfo
Copy link
Contributor Author

Usually, I use workflow templates instead of directly using all templates :)

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daffainfo thanks for adding those workflows, I've fixed multiple workflows related to matcher name based subtemplates, you can refer to "Matcher Name based condition check" section at https://nuclei.projectdiscovery.io/templating-guide/workflows/ for more information.

@ehsandeep ehsandeep merged commit 0e39fd0 into projectdiscovery:master Jan 12, 2022
@daffainfo
Copy link
Contributor Author

Thankyou @ehsandeep i think i need to learn more about creating workflow templates 🙏🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants