Disable HTTP/2 fallback when using -pr http11 flag#2392
Open
MAVRICK-1 wants to merge 1 commit intoprojectdiscovery:devfrom
Open
Disable HTTP/2 fallback when using -pr http11 flag#2392MAVRICK-1 wants to merge 1 commit intoprojectdiscovery:devfrom
MAVRICK-1 wants to merge 1 commit intoprojectdiscovery:devfrom
Conversation
WalkthroughAdds logic to disable HTTP/2 fallback in retryablehttp when HTTP/1.1-only protocol mode is selected in httpx. This ensures that when users explicitly request HTTP/1.1, the client respects that choice instead of automatically falling back to HTTP/2 on connection errors. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes
-pr http11flag being ignored due to HTTP/2 fallback in retryablehttp-go.When using
-pr http11, httpx disables HTTP/2 at transport level but retryablehttp-go automatically falls back to HTTP/2 client on certain errors. This PR setsDisableHTTP2Fallback = truewhen http11 mode is enabled.Depends on: projectdiscovery/retryablehttp-go#522
Proof
Shows HTTP/1.1 only, no HTTP/2 fallback on malformed response errors.
Checklist
Fixes #2240
/claim #2240
Summary by CodeRabbit