Skip to content

fix favicon host header issue #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 1 commit into from
Sep 7, 2023
Merged

fix favicon host header issue #1339

ehsandeep merged 1 commit into from
Sep 7, 2023

Conversation

@dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Aug 31, 2023

Closes #1333.

before:

$ go run . -u https://spirit.com.au/ -favicon

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.3.4 (latest)
https://spirit.com.au/

after:

$ go run . -u https://spirit.com.au/ -favicon

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.3.4 (latest)
https://spirit.com.au/ [1668213002]

@dogancanbakir dogancanbakir self-assigned this Aug 31, 2023
@dogancanbakir dogancanbakir linked an issue Aug 31, 2023 that may be closed by this pull request
Incorrect host header used for favicon grab if stored on a different host #1333
Closed
RamanaReddy0M
RamanaReddy0M approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit d814260 into dev Sep 7, 2023
@ehsandeep ehsandeep deleted the fix_favicon_host_header branch September 7, 2023 09:18
@chenrui333 chenrui333 mentioned this pull request Sep 14, 2023
Merged
@ppb007 ppb007 mentioned this pull request Sep 15, 2023
Closed
@ppb007 ppb007 mentioned this pull request Oct 31, 2023
Closed
@ppb007 ppb007 mentioned this pull request Nov 13, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jan 16, 2024
Closed
@ppb007 ppb007 mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

+1 more reviewer

@RamanaReddy0M RamanaReddy0M RamanaReddy0M approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dogancanbakir dogancanbakir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect host header used for favicon grab if stored on a different host

3 participants

@dogancanbakir @ehsandeep @RamanaReddy0M