Skip to content

Conversation

@RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Jun 26, 2023

#1142 -tls-grab option doesn't work with -ztls mode

@RamanaReddy0M RamanaReddy0M self-assigned this Jun 26, 2023
@RamanaReddy0M RamanaReddy0M linked an issue Jun 26, 2023 that may be closed by this pull request
@RamanaReddy0M
Copy link
Contributor Author

✗ ./httpx -u google.com -ztls -tls-grab -json -silent | jq .tls
{
  "host": "google.com",
  "port": "443",
  "probe_status": true,
  "tls_version": "tls12",
  "cipher": "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
  "not_before": "2023-05-29T08:16:17Z",
  "not_after": "2023-08-21T08:16:16Z",
  "subject_dn": "CN=*.google.com",
  "subject_cn": "*.google.com",
  "subject_an": [
    "*.google.com",
    "*.appengine.google.com",
    "*.bdn.dev",
    "*.origin-test.bdn.dev",
    "*.cloud.google.com",
    "*.crowdsource.google.com",
    "*.datacompute.google.com",
    "*.google.ca",
      ...
  ],
  "serial": "DB:68:49:6B:4E:17:50:F5:12:99:FA:7B:ED:B1:22:B8",
  "issuer_dn": "CN=GTS CA 1C3, O=Google Trust Services LLC, C=US",
  "issuer_cn": "GTS CA 1C3",
  "issuer_org": [
    "Google Trust Services LLC"
  ],
  "fingerprint_hash": {
    "md5": "5c86a077182cd855f21b8d80b363100f",
    "sha1": "a8b52bde3bdbfbab1b787ae68fde23236cab863b",
    "sha256": "2aa97ca45c98e14d3cd12af65b396f1a51731b94ec4b5f705a8920116775adc2"
  },
  "wildcard_certificate": true,
  "tls_connection": "ztls"
}

@RamanaReddy0M RamanaReddy0M requested a review from Mzack9999 June 26, 2023 17:24
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 27, 2023
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

$ go run . -u scanme.sh -ztls -tls-grab -json -silent | jq .tls
{
  "host": "scanme.sh",
  "port": "443",
  "probe_status": true,
  "tls_version": "tls12",
  "cipher": "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
  "self_signed": true,
  "mismatched": true,
  "not_before": "2022-06-07T15:18:51Z",
  "not_after": "2032-06-04T15:18:51Z",
  "subject_dn": "CN=scanme, O=pd",
  "subject_cn": "scanme",
  "subject_org": [
    "pd"
  ],
  "serial": "EF:00:99:77:D2:1E:A4:3F",
  "issuer_dn": "CN=scanme, O=pd",
  "issuer_cn": "scanme",
  "issuer_org": [
    "pd"
  ],
  "fingerprint_hash": {
    "md5": "eacf1e9b4acca9168b43f84a9bfaa7c5",
    "sha1": "550837ef878d58c92820e9498e3807c6bd7184ec",
    "sha256": "ebbf69a9e7ba65b51fa12cd44105055c2c2c250706e9795fab219d3d5dff5fac"
  },
  "tls_connection": "ztls"
}

@Mzack9999 Mzack9999 requested a review from ehsandeep June 27, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-tls-grab option doesn't work with -ztls mode

3 participants