Skip to content

Add support to skip decode #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 1 commit into from
Mar 29, 2023
Merged

Add support to skip decode #1055

ehsandeep merged 1 commit into from
Mar 29, 2023

Conversation

@Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Mar 21, 2023 •
edited
Loading

Closes #971

Implemented with new -no-decode CLI flag:

$ echo 'https://zc-console.taobao.com/favicon.ico' | go run . -silent -json -irrb | jq .body -j | base64 -d | wc
       9      73    2246
$ echo 'https://zc-console.taobao.com/favicon.ico' | go run . -silent -json -irrb -no-decode | jq .body -j | base64 -d | wc
       9      63    1863

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 21, 2023
@Mzack9999 Mzack9999 self-assigned this Mar 21, 2023
@Mzack9999 Mzack9999 linked an issue Mar 21, 2023 that may be closed by this pull request
-irrb Sometimes returns corrupted base64 body #971
Closed
ShubhamRasal
ShubhamRasal approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@ShubhamRasal ShubhamRasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ehsandeep ehsandeep merged commit 1defd0a into dev Mar 29, 2023
@ehsandeep ehsandeep deleted the issue-971-b64-body branch March 29, 2023 13:36
@ppb007 ppb007 mentioned this pull request Apr 28, 2023
Closed
@ppb007 ppb007 mentioned this pull request May 10, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jun 13, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jun 21, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jul 23, 2023
Closed
@ppb007 ppb007 mentioned this pull request Sep 15, 2023
Closed
@ppb007 ppb007 mentioned this pull request Oct 31, 2023
Closed
@ppb007 ppb007 mentioned this pull request Nov 13, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jan 16, 2024
Closed
@ppb007 ppb007 mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@ShubhamRasal ShubhamRasal ShubhamRasal approved these changes

Assignees

@Mzack9999 Mzack9999

Labels

Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

-irrb Sometimes returns corrupted base64 body

3 participants

@Mzack9999 @ehsandeep @ShubhamRasal