Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude raw dns response from JSONL output #410

Merged
merged 9 commits into from
Jul 11, 2023

Conversation

jhnmthw
Copy link
Contributor

@jhnmthw jhnmthw commented Jul 8, 2023

Added a new flag -or, -omit-raw which excludes raw dns response from JSONL output.

@ehsandeep ehsandeep changed the base branch from main to dev July 8, 2023 20:35
@ehsandeep ehsandeep linked an issue Jul 8, 2023 that may be closed by this pull request
@jhnmthw
Copy link
Contributor Author

jhnmthw commented Jul 8, 2023

image

@olearycrew
Copy link
Contributor

Thanks for this and for entering the Countdown to Discovery contest @jhnmthw !

@ehsandeep ehsandeep requested review from Mzack9999 and removed request for tarunKoyalwar July 11, 2023 13:29
@jhnmthw
Copy link
Contributor Author

jhnmthw commented Jul 11, 2023

Thanks for this and for entering the Countdown to Discovery contest @jhnmthw !

You're welcome and the pleasure was mine to contribute to open source.

Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

$ echo google.com | go run . -json
...
host":"google.com","ttl":93,"resolver":["1.0.0.1:53"],"a":["142.251.209.46"],"all":["google.com.\t93\tIN\tA\t142.251.209.46","\n;; OPT PSEUDOSECTION:\n; EDNS: version 0; flags:; udp: 1232"],"status_code":"NOERROR","timestamp":"2023-07-11T21:00:50.2070053+02:00"}
$ echo google.com | go run . -json -or
...
{"host":"google.com","ttl":79,"resolver":["1.0.0.1:53"],"a":["142.251.209.46"],"status_code":"NOERROR","timestamp":"2023-07-11T21:00:56.0704893+02:00"}

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jul 11, 2023
@Mzack9999 Mzack9999 merged commit 00e32e6 into projectdiscovery:dev Jul 11, 2023
10 checks passed
@jhnmthw jhnmthw deleted the omit-raw branch July 12, 2023 09:48
@jhnmthw jhnmthw restored the omit-raw branch July 12, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to exclude raw dns response from JSONL output
4 participants