Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Ignore empty fragments. #10

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 27, 2020

When developing a test document, you might comment out some fragment,
but leave the YAML document separator in place. This should result in
an empty fragment rather than an invalid fragment, since the latter
just generates an annoying and unnecessary error.

Signed-off-by: James Peach jpeach@vmware.com

When developing a test document, you might comment out some fragment,
but leave the YAML document separator in place. This should result in
an empty fragment rather than an invalid fragment, since the latter
just generates an annoying and unnecessary error.

Signed-off-by: James Peach <jpeach@vmware.com>
@jpeach jpeach force-pushed the ignore-empty-fragments branch from ebe886d to 25b78f0 Compare July 27, 2020 00:50
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, though I have zero familiarity with the code in this repo.

@jpeach jpeach merged commit b155e1c into projectcontour:master Jul 27, 2020
@jpeach jpeach deleted the ignore-empty-fragments branch July 27, 2020 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants