Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioner: customize the 'bootstrap's cmdline param: dns-lookup-family #6699

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

izturn
Copy link
Member

@izturn izturn commented Oct 10, 2024

Signed-off-by: Gang Liu gang.liu@daocloud.io

When running in the v4 environment, the default auto will trigger annoying CoreDNS logs likes:

[Info] 10.21.16.16:38784 - 19433 "AAAA IN xxx, udp 43 false f12" SERVFAIL qr,aa,rd,ra 43 0.0000447s

so add an option to customize it

@izturn izturn requested a review from a team as a code owner October 10, 2024 02:26
@izturn izturn requested review from skriss and sunjayBhatia and removed request for a team October 10, 2024 02:26
@izturn izturn self-assigned this Oct 10, 2024
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and clayton-gonsalves and removed request for a team October 10, 2024 02:27
@izturn izturn added kind/feature Categorizes issue or PR as related to a new feature. release-note/minor A minor change that needs about a paragraph of explanation in the release notes. area/gateway-provisioner Issues or PRs related to the Gateway provisioner labels Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.75%. Comparing base (54ceade) to head (ac93088).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
internal/provisioner/controller/gatewayclass.go 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6699      +/-   ##
==========================================
- Coverage   81.76%   81.75%   -0.01%     
==========================================
  Files         133      133              
  Lines       15944    15953       +9     
==========================================
+ Hits        13037    13043       +6     
- Misses       2614     2617       +3     
  Partials      293      293              
Files with missing lines Coverage Δ
internal/provisioner/controller/gateway.go 59.40% <100.00%> (+0.34%) ⬆️
internal/provisioner/model/model.go 100.00% <100.00%> (ø)
...nternal/provisioner/objects/dataplane/dataplane.go 87.67% <100.00%> (+0.03%) ⬆️
internal/provisioner/controller/gatewayclass.go 70.35% <40.00%> (-0.79%) ⬇️

Signed-off-by: gang.liu <gang.liu@daocloud.io>
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-provisioner Issues or PRs related to the Gateway provisioner kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant