Add per route metrics option #6531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtreffer-rddt
requested review from
tsaarni and
skriss
and removed request for
a team
sunjayBhatia
requested review from
a team,
davinci26 and
clayton-gonsalves
and removed request for
a team
|
Hi @rtreffer-rddt! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6531 +/- ##
==========================================
- Coverage 81.76% 81.72% -0.05%
==========================================
Files 133 133
Lines 15942 15964 +22
==========================================
+ Hits 13035 13046 +11
- Misses 2614 2620 +6
- Partials 293 298 +5
|
rtreffer-rddt
force-pushed
the
add-per-route-metrics-option
branch
from
1ad1564
to
6f84ff2
Compare
clayton-gonsalves
added
the
release-note/minor
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
Signed-off-by: Ahmad Karimi <ak12hastam@gmail.com> Signed-off-by: René Treffer <rene.treffer@reddit.com>
Signed-off-by: Ahmad Karimi <ak12hastam@gmail.com> Signed-off-by: René Treffer <rene.treffer@reddit.com>
Signed-off-by: Ahmad Karimi <ak12hastam@gmail.com>
Routes in an HTTPProxy object are a list. For metrics purposes these should be distinguishable. We can number them by route index (route0, route1, route2....) and optionally allow a RouteTag override (e.g. login). Signed-off-by: René Treffer <rene.treffer@reddit.com>
Signed-off-by: René Treffer <rene.treffer@reddit.com>
Signed-off-by: René Treffer <rene.treffer@reddit.com>
rtreffer-rddt
force-pushed
the
add-per-route-metrics-option
branch
from
6f84ff2
to
4f4fbc0
Compare
|
Rebased on latest main branch |
tsaarni
removed
the
lifecycle/stale
Signed-off-by: René Treffer <rene.treffer@reddit.com>
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #5535
I made sure I keep all signed-off and author attributions intact, I added a signed-off when I changed things. The rebase required mostly a change from
ref.Totoptr.To.There is one significant addition. HTTPProxy objects can define multiple routes, so we would need a way to distinguish routes. For that I'll per default generate a router+index suffix (
route0,route1, ...). There is optionally also support for a RouteTag that can be used for semantic names.Fixes #4637