-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gateway-api to v1.1.0 #6398
Bump gateway-api to v1.1.0 #6398
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6398 +/- ##
==========================================
- Coverage 81.63% 81.61% -0.03%
==========================================
Files 133 133
Lines 15862 15858 -4
==========================================
- Hits 12949 12942 -7
- Misses 2619 2621 +2
- Partials 294 295 +1
|
Looks like Seems like we should either push back on this (expect a TLS error instead) or we'll have to ensure a fallback certificate is configured and enabled so we can terminate TLS and return an HTTP response |
hm looks like i approved this test and it passed before, will have to take another look into why its failing in CI |
looks like i approved before the negative hostname test was added and didnt re-check it later |
realized this is probably a contour deficiency, I don't think we generate a filter chain if there is no httproute attached to a listener |
upgrade test probably failing since we started reconciling v1alpha3 backendtlspolicy and that has not been applied to the cluster as part of the upgrade |
Listener isolation test failing, needs this fix: #6162 |
disabled backendtlspolicy feature in provisioner upgrade test since the upgrade from v1.0.0 to v1.1.0 of gw api removes the old api version and adds v1alpha3 of the resource i tried instead to install the newer crds as part of the upgrade but the grpcroute crd going to v1 also causes some issues, could be more surgical but this felt easier for now |
a344c67
to
24a3040
Compare
nvm, just fixed the crd install as part of the upgrade found a bug when setting multiple disabled features in the provisioner |
24a3040
to
6b66aa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a couple nits so far, still need to review the BackendTLSPolicy changes in a little more detail but not too concerned about it.
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
so we can ignore the gateway crds and other failing files for now Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
6b66aa2
to
5b88d5a
Compare
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple typos
- update go module dependency and regenerate CRDs - updates to reconciling GRPCRoute v1 - v1alpha2 of BackendTLSPolicy has been removed, update to reconcile v1alpha3 - disable a couple new conformance tests which will be fixed in subsequent PRs - provisioner now sets supported CRD version as v1.1.0 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Fixes: #6397