Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump logrusr to v4.0.0 #5806

Merged
merged 2 commits into from
Oct 9, 2023
Merged

deps: Bump logrusr to v4.0.0 #5806

merged 2 commits into from
Oct 9, 2023

Commits on Oct 9, 2023

  1. deps: Bump logrusr to v4.0.0 

    Fixes data races found in projectcontour#5805

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
    @sunjayBhatia
    sunjayBhatia committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a67919c View commit details
    Browse the repository at this point in the history

  2. Remove testing around V().Info() 

    logrusr has changed behavior since v3.0.0, it now tries to mimic logrus
log levels with the V() level, see:
bombsimon/logrusr@9f3fd50

In practice client-go checks if a certain verbosity level is enabled and
initializes a different logger based on that and then uses Info(f) logs,
rather than the V().Info() construction.

This commit removes the testing of log lines written with V() guarding
them and rather just tests the expected verbosity is enabled or not.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
    @sunjayBhatia
    sunjayBhatia committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    60cb719 View commit details
    Browse the repository at this point in the history