Design: Endpoint slice support #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
clayton-gonsalves
requested review from
tsaarni and
stevesloka
and removed request for
a team
clayton-gonsalves
added
the
kind/design
clayton-gonsalves
requested review from
skriss,
sunjayBhatia and
a team
and removed request for
tsaarni and
stevesloka
clayton-gonsalves
added
the
release-note/none-required
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5703 +/- ##
==========================================
- Coverage 78.60% 78.56% -0.04%
==========================================
Files 138 138
Lines 19155 19163 +8
==========================================
Hits 15056 15056
- Misses 3812 3820 +8
Partials 287 287 |
skriss
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Thanks for the design doc @clayton-gonsalves, apologies for the delay in reviewing. Added a few comments/questions.
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
skriss
approved these changes
Sep 14, 2023
tsaarni
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Since the processing of EndpointSlices and Endpoints would be mutually exclusive maybe it could be mentioned that Endpoints where user has disabled mirroring will not be processed by Contour.
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
addressed in 45a8a96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design proposal to address #2696