Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set specific stat_prefix for each resource #5539

Closed
wants to merge 2 commits into from
Closed

Set specific stat_prefix for each resource #5539

wants to merge 2 commits into from

Conversation

therealak12
Copy link
Contributor

@therealak12 therealak12 commented Jul 1, 2023 •
edited
Loading

This is another way of setting StatPrefix as mentioned in pull#5535.

It sets namespace_resourcetype_resourcename as the StatPrefix.

@therealak12
add envoy stat_prefix support for httpproxy
83d083b 
Signed-off-by: Ahmad Karimi <ak12hastam@gmail.com>
@therealak12 therealak12 requested a review from a team as a code owner July 1, 2023 13:31
@therealak12 therealak12 requested review from tsaarni and skriss and removed request for a team July 1, 2023 13:31
@therealak12
set specific stat prefix per route
add9311 
Signed-off-by: Ahmad Karimi <ak12hastam@gmail.com>
@izturn izturn mentioned this pull request Jul 4, 2023
Closed
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2023
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this Aug 16, 2023
@m-yosefpor m-yosefpor deleted the per-host-prefix branch September 27, 2023 09:35
@wilsonwu
Copy link
Member

Seems need to reopen.

@therealak12
Copy link
Contributor Author

therealak12 commented Oct 13, 2023 •
edited
Loading

Seems need to reopen.

I've applied the changes in PR#5535. This is not required anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@skriss skriss Awaiting requested review from skriss skriss is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therealak12 @wilsonwu