-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway API: add support for TCPRoute #5471
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5471 +/- ##
==========================================
- Coverage 78.28% 78.12% -0.16%
==========================================
Files 138 139 +1
Lines 18648 18833 +185
==========================================
+ Hits 14599 14714 +115
- Misses 3768 3835 +67
- Partials 281 284 +3
|
aadadc9
to
0c6b21f
Compare
0c6b21f
to
ac74e86
Compare
9b1d342
to
67880f6
Compare
2aae894
to
af42608
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! basically we add a new property on a listener separate from virtualhost since with plain tcp we can't do any sni/hostname routing and set up the tcp proxy filter accordingly 👍🏽
wdyt about an e2e test for this? might be a while until there is a relevant one in upstream
af42608
to
7c68b04
Compare
I added a basic one, I should probably also circle back and add one to the provisioner suite for a Gateway with many Listener ports, and can include a TCP listener as part of that, just to exercise the non-standard ports. Will do that in a separate PR. |
Updates projectcontour#5321. Signed-off-by: Steve Kriss <krisss@vmware.com>
7c68b04
to
ca6d1b2
Compare
Closes #5321.