Bump Gateway API to v0.7.1 #5353

sunjayBhatia · 2023-05-10T20:27:16Z

To ensure compatibility with upcoming release

Fixes: #5336
Fixes: #5414

sunjayBhatia · 2023-05-10T20:27:51Z

Will update dependency tag/PR title as new rc/GA versions become available, looks like rc2 is coming soon

sunjayBhatia · 2023-05-10T21:28:02Z

rc2 image not out yet

codecov · 2023-05-10T23:52:08Z

Codecov Report

Merging #5353 (ccd11ce) into main (5fc91fa) will not change coverage.
The diff coverage is 66.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5353   +/-   ##
=======================================
  Coverage   78.18%   78.18%           
=======================================
  Files         138      138           
  Lines       18496    18496           
=======================================
  Hits        14462    14462           
  Misses       3757     3757           
  Partials      277      277

Impacted Files	Coverage Δ
internal/gatewayapi/helpers.go	`87.94% <0.00%> (ø)`
internal/dag/gatewayapi_processor.go	`94.34% <100.00%> (ø)`

sunjayBhatia · 2023-05-11T13:34:56Z

Re-running to see if the TLSRoute test failure was a flake

Otherwise, we have the ObservedGeneration bump test failing and more redirect tests failing

TestGatewayConformance/GatewayObservedGenerationBump
- Fails because the test adds a second HTTP Listener to the Gateway and expects Programmed=True: https://github.com/kubernetes-sigs/gateway-api/blob/v0.7.0-rc2/conformance/tests/gateway-observed-generation-bump.go#L67-L74
TestGatewayConformance/HTTPRouteRedirectPortAndScheme
- http-listener-on-8080/0_request_to_'/scheme-nil-and-port-nil'_should_receive_a_302 fails expecting port 8080 to be returned (since it does not specify a port redirect and envoy strips the original request port)
- http-listener-on-80 tests all pass
- https-listener-on-443 all the tests fail w/ status 421 since they are not setting a proper host, as-is the requested server name is example but the authority ends up actually just being the Gateway IP
  - once the tests are fixed, we also need to change this line to * rather than *. to cover the new case Gateway API has introduced, no hostnames on the GW or Route mean the SNI match is on *:
    
    contour/internal/envoy/v3/listener.go
    
    Line 696 in 020d782
    
    if strings.HasPrefix(fqdn, "*.") {

[2023-05-18 21:42:12.536][31][debug][conn_handler] [source/extensions/listener_managers/listener_manager/active_tcp_listener.cc:155] [C22] new connection from 172.18.0.1:48360
[2023-05-18 21:42:12.536][25][debug][filter] [source/extensions/filters/listener/tls_inspector/tls_inspector.cc:117] tls:onServerName(), requestedServerName: example
[2023-05-18 21:42:12.536][25][debug][conn_handler] [source/extensions/listener_managers/listener_manager/active_tcp_listener.cc:155] [C23] new connection from 172.18.0.1:48334
[2023-05-18 21:42:12.536][25][debug][filter] [source/extensions/filters/listener/tls_inspector/tls_inspector.cc:117] tls:onServerName(), requestedServerName: example
[2023-05-18 21:42:12.536][25][debug][conn_handler] [source/extensions/listener_managers/listener_manager/active_tcp_listener.cc:155] [C24] new connection from 172.18.0.1:48368
[2023-05-18 21:42:12.539][19][debug][filter] [source/extensions/filters/listener/tls_inspector/tls_inspector.cc:117] tls:onServerName(), requestedServerName: example
[2023-05-18 21:42:12.539][19][debug][conn_handler] [source/extensions/listener_managers/listener_manager/active_tcp_listener.cc:155] [C25] new connection from 172.18.0.1:48330
[2023-05-18 21:42:12.541][31][debug][http] [source/common/http/conn_manager_impl.cc:349] [C22] new stream
[2023-05-18 21:42:12.541][31][debug][http] [source/common/http/conn_manager_impl.cc:1039] [C22][S13650922495304120506] request headers complete (end_stream=true):
':authority', '172.18.255.202'
':path', '/scheme-nil-and-port-443'
':method', 'GET'
'user-agent', 'Go-http-client/1.1'
'x-echo-set-header', ''
'accept-encoding', 'gzip'

~~TestGatewayConformance/TLSRouteSimpleSameNamespace~~ looks like a flake

sunjayBhatia · 2023-05-18T22:13:45Z

made some updates to the comment above, will have a PR to fix GW API tests coming shortly

Issue: kubernetes-sigs/gateway-api#2038

PR: kubernetes-sigs/gateway-api#2039

sunjayBhatia · 2023-05-22T16:49:27Z

.github/workflows/prbuild.yaml

@@ -76,6 +76,8 @@ jobs:
          ./hack/actions/install-kubernetes-toolchain.sh $GITHUB_WORKSPACE/bin
          echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH
      - name: generate
+        env:


will undo changes here once we have another tagged patch release

sunjayBhatia · 2023-05-22T17:40:35Z

New failing test: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/1_request_to_'very.specific.com:1234/s1'_should_go_to_infra-backend-v1

fails with error

http.go:222: Response expectation failed for request: {URL: {Scheme:http Opaque: User: Host:172.18.255.205 Path:/s1 RawPath: OmitHost:false ForceQuery:false RawQuery: Fragment: RawFragment:}, Host: very.specific.com:1234, Protocol: HTTP, Method: GET, Headers: map[X-Echo-Set-Header:[]], UnfollowRedirect: false, Server: , CertPem: <truncated>, KeyPem: <truncated>} not ready yet: expected host to be very.specific.com:1234, got very.specific.com (after 1µs)

another instance of port stripping.

sunjayBhatia · 2023-05-22T18:23:46Z

Another failing test, looks like it was added after my review, see: https://github.com/kubernetes-sigs/gateway-api/pull/1984/files#r1200873543

We implement method matching using the :method pseudoheader, so if you have only a method in one route match and only a single header in another, I believe whichever one comes first in the list will currently "win"

We'll need to add some explicit logic to get this right regardless of match order once the spec is updated with a precedence order

sunjayBhatia · 2023-05-22T19:18:45Z

rebased on #5390 to get the fixes from there

sunjayBhatia · 2023-06-02T00:18:04Z

looks like the webhook image isn't out yet for 0.7.1

sunjayBhatia · 2023-06-05T17:35:47Z

Might have to undo #3458 to get TestGatewayConformance/HTTPRouteHostnameIntersection passing again as the tests expect the port from the Host header is passed upstream and right now we're stripping it

The test passes if we undo the strip host port configuration and add back the virtualhost domain match for hostname + ":*"

The reason we added this in the first place is you can't match on *.foo.com:* so wildcard hostname + "ignoring" port isn't allowed in Envoy: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-field-config-route-v3-virtualhost-domains

sunjayBhatia · 2023-06-05T19:21:07Z

Filed kubernetes-sigs/gateway-api#2091

sunjayBhatia · 2023-06-05T20:36:09Z

rebased on #5437

sunjayBhatia · 2023-06-05T21:15:58Z

Conformance is all passing, just got to fix whatever is up with e2e tests from #5437

skriss

🚀 thanks for all the work on this one @sunjayBhatia!

skriss · 2023-06-05T22:04:41Z

test/conformance/gatewayapi/gateway_conformance_test.go

+			// Test adds multiple HTTP Listeners to the Gateway with
+			// distinct ports. This is not supported in Contour until
+			// multi-Listener support is added.
+			// See: https://github.com/projectcontour/contour/issues/4960
+			tests.GatewayObservedGenerationBump.ShortName,


I've confirmed that this test will pass with #5160, will update that PR to remove it from the skipped tests

skriss · 2023-06-05T22:05:58Z

This PR still needs its own changelog file

To ensure compatibility with upcoming release Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

to avoid controller-runtime panic when no log sink is set Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

panics due to warnings being logged in controller-runtime Also just curious to see what the warnings are Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

sunjayBhatia added the release-note/small A small change that needs one line of explanation in the release notes. label May 10, 2023

sunjayBhatia requested a review from a team as a code owner May 10, 2023 20:27

sunjayBhatia requested review from tsaarni and skriss and removed request for a team May 10, 2023 20:27

sunjayBhatia changed the title ~~Bump Gateway API to v0.7.0-rc1~~ Bump Gateway API to v0.7.0-rc2 May 10, 2023

skriss mentioned this pull request May 15, 2023

build(deps): bump sigs.k8s.io/gateway-api from 0.6.2 to 0.7.0 #5370

Closed

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch from 2729a8f to 14019e7 Compare May 18, 2023 20:30

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch 2 times, most recently from 5f3d109 to e4c6a18 Compare May 22, 2023 16:49

sunjayBhatia commented May 22, 2023

View reviewed changes

sunjayBhatia changed the title ~~Bump Gateway API to v0.7.0-rc2~~ Bump Gateway API to v0.7.x May 22, 2023

sunjayBhatia mentioned this pull request May 22, 2023

internal/envoy/v3: Loosen FilterMisdirectedRequests helper #5390

Merged

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch from e4c6a18 to 7619db3 Compare May 22, 2023 19:18

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch 3 times, most recently from 9636a53 to 7f89cd0 Compare May 23, 2023 17:58

skriss mentioned this pull request May 25, 2023

build(deps): bump github.com/cert-manager/cert-manager from 1.11.2 to 1.12.1 #5407

Merged

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch 3 times, most recently from 683e9f1 to d342f5a Compare June 1, 2023 21:36

sunjayBhatia mentioned this pull request Jun 5, 2023

Further clarification on hostname matching and forwarding when Host header includes a port kubernetes-sigs/gateway-api#2091

Closed

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch 2 times, most recently from 932c64f to beb66f0 Compare June 5, 2023 20:35

sunjayBhatia changed the title ~~Bump Gateway API to v0.7.x~~ Bump Gateway API to v0.7.1 Jun 5, 2023

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch from beb66f0 to e1347af Compare June 5, 2023 21:52

skriss approved these changes Jun 5, 2023

View reviewed changes

sunjayBhatia added 11 commits June 5, 2023 23:14

Bump Gateway API to v0.7.0-rc1

c156524

To ensure compatibility with upcoming release Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

linter/compilation fixes

ff07133

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Bump to rc2

54c273b

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Don't run Mesh tests

99d06d3

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Bump to release branch for upcoming fixes

23dab5d

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Bump to 0.7.1

3376c0c

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

call log.SetLogger

4ca8fbe

to avoid controller-runtime panic when no log sink is set Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Call log.SetLogger in e2e tests

a813c20

panics due to warnings being logged in controller-runtime Also just curious to see what the warnings are Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

add ClientSet for mirroring tests

ef58854

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

not super useful to have file logged

04ab44c

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

Pare down skipped tests

685a968

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

sunjayBhatia force-pushed the bump-gw-api-0.7.0 branch from e1347af to 685a968 Compare June 5, 2023 23:15

changelog

ccd11ce

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>

sunjayBhatia added release-note/minor A minor change that needs about a paragraph of explanation in the release notes. and removed release-note/small A small change that needs one line of explanation in the release notes. labels Jun 5, 2023

sunjayBhatia merged commit d42b892 into projectcontour:main Jun 6, 2023

sunjayBhatia deleted the bump-gw-api-0.7.0 branch June 6, 2023 14:14

skriss mentioned this pull request Jun 6, 2023

test flake: Gateway API TLSRoute test #5274

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Gateway API to v0.7.1 #5353

Bump Gateway API to v0.7.1 #5353

sunjayBhatia commented May 10, 2023 •

edited by skriss

Loading

sunjayBhatia commented May 10, 2023 •

edited

Loading

sunjayBhatia commented May 10, 2023

codecov bot commented May 10, 2023 •

edited

Loading

sunjayBhatia commented May 11, 2023 •

edited

Loading

sunjayBhatia commented May 18, 2023 •

edited

Loading

sunjayBhatia May 22, 2023

sunjayBhatia commented May 22, 2023 •

edited

Loading

sunjayBhatia commented May 22, 2023 •

edited

Loading

sunjayBhatia commented May 22, 2023

sunjayBhatia commented Jun 2, 2023 •

edited

Loading

sunjayBhatia commented Jun 5, 2023 •

edited

Loading

sunjayBhatia commented Jun 5, 2023

sunjayBhatia commented Jun 5, 2023

sunjayBhatia commented Jun 5, 2023

skriss left a comment

skriss Jun 5, 2023

skriss commented Jun 5, 2023

Bump Gateway API to v0.7.1 #5353

Bump Gateway API to v0.7.1 #5353

Conversation

sunjayBhatia commented May 10, 2023 • edited by skriss Loading

sunjayBhatia commented May 10, 2023 • edited Loading

sunjayBhatia commented May 10, 2023

codecov bot commented May 10, 2023 • edited Loading

Codecov Report

sunjayBhatia commented May 11, 2023 • edited Loading

sunjayBhatia commented May 18, 2023 • edited Loading

sunjayBhatia May 22, 2023

Choose a reason for hiding this comment

sunjayBhatia commented May 22, 2023 • edited Loading

sunjayBhatia commented May 22, 2023 • edited Loading

sunjayBhatia commented May 22, 2023

sunjayBhatia commented Jun 2, 2023 • edited Loading

sunjayBhatia commented Jun 5, 2023 • edited Loading

sunjayBhatia commented Jun 5, 2023

sunjayBhatia commented Jun 5, 2023

sunjayBhatia commented Jun 5, 2023

skriss left a comment

Choose a reason for hiding this comment

skriss Jun 5, 2023

Choose a reason for hiding this comment

skriss commented Jun 5, 2023

sunjayBhatia commented May 10, 2023 •

edited by skriss

Loading

sunjayBhatia commented May 10, 2023 •

edited

Loading

codecov bot commented May 10, 2023 •

edited

Loading

sunjayBhatia commented May 11, 2023 •

edited

Loading

sunjayBhatia commented May 18, 2023 •

edited

Loading

sunjayBhatia commented May 22, 2023 •

edited

Loading

sunjayBhatia commented May 22, 2023 •

edited

Loading

sunjayBhatia commented Jun 2, 2023 •

edited

Loading

sunjayBhatia commented Jun 5, 2023 •

edited

Loading