move ContourConfiguration enum validation to controller #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes kubebuilder enum validations from ContourConfiguration CRD and adds equivalent logic to the Validate() function called by the controller. This enables new allowed values to be added without constituting a breaking API change. Closes projectcontour#4510. Signed-off-by: Steve Kriss <krisss@vmware.com> Co-authored-by: Nick Young <ynick@vmware.com>
skriss
requested review from
tsaarni,
sunjayBhatia and
youngnick
and removed request for
a team
skriss
commented
May 3, 2022
skriss
added
the
release-note/small
Codecov Report
@@ Coverage Diff @@
## main #4511 +/- ##
==========================================
- Coverage 76.77% 76.75% -0.02%
==========================================
Files 139 139
Lines 12728 12728
==========================================
- Hits 9772 9770 -2
- Misses 2702 2704 +2
Partials 254 254
|
sunjayBhatia
approved these changes
May 3, 2022
skriss
added a commit
to skriss/contour
that referenced
this pull request
May 9, 2022
…ur#4511) Removes kubebuilder enum validations from ContourConfiguration CRD and adds equivalent logic to the Validate() function called by the controller. This enables new allowed values to be added without constituting a breaking API change. Closes projectcontour#4510. Signed-off-by: Steve Kriss <krisss@vmware.com> Co-authored-by: Nick Young <ynick@vmware.com>
skriss
added a commit
that referenced
this pull request
May 9, 2022
Removes kubebuilder enum validations from ContourConfiguration CRD and adds equivalent logic to the Validate() function called by the controller. This enables new allowed values to be added without constituting a breaking API change. Closes #4510. Signed-off-by: Steve Kriss <krisss@vmware.com> Co-authored-by: Nick Young <ynick@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes kubebuilder enum validations from ContourConfiguration
CRD and adds equivalent logic to the Validate() function
called by the controller. This enables new allowed values
to be added without constituting a breaking API change.
Closes #4510.
Signed-off-by: Steve Kriss krisss@vmware.com
Co-authored-by: Nick Young ynick@vmware.com