Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: update to v0.4.3, add validating webhook #4489

Merged
merged 1 commit into from
May 6, 2022
Merged

Gateway API: update to v0.4.3, add validating webhook #4489

merged 1 commit into from
May 6, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented Apr 21, 2022 •
edited
Loading

Updates the version of Gateway API to
v0.4.3 and adds the validating webhook
from that version to Contour's example
YAML files and E2E tests.

Closes #3807.

Signed-off-by: Steve Kriss krisss@vmware.com

@skriss skriss requested a review from a team as a code owner April 21, 2022 23:37
@skriss skriss requested review from sunjayBhatia and youngnick and removed request for a team April 21, 2022 23:37
@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label Apr 21, 2022
skriss
skriss commented Apr 21, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
skriss
skriss commented Apr 21, 2022
View reviewed changes
test/e2e/gateway/invalid_forward_to_test.go
@@ -63,28 +63,6 @@ func testInvalidForwardTo(namespace string) {
},
},
},

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This route rule without a port in the backend ref is now rejected by the webhook, so dropping it to allow the test to pass.

@codecov
Copy link

codecov bot commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #4489 (19c7fd5) into main (93d8020) will not change coverage.
The diff coverage is n/a.

❗ Current head 19c7fd5 differs from pull request most recent head a8cf888. Consider uploading reports for the commit a8cf888 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4489   +/-   ##
=======================================
  Coverage   76.77%   76.77%           
=======================================
  Files         139      139           
  Lines       12728    12728           
=======================================
  Hits         9772     9772           
  Misses       2702     2702           
  Partials      254      254

@skriss skriss added the do not merge Don't merge this PR until this label is removed. label Apr 25, 2022
@skriss
Copy link
Member Author

skriss commented Apr 25, 2022 •
edited
Loading

Thinking we should hold this one until there is a release-tagged image for the webhook, otherwise we're using a latest image tag which will not be stable over time (

contour/examples/gateway/01-admission_webhook.yaml

Line 64 in 5255e0f

image: gcr.io/k8s-staging-gateway-api/admission-server:latest
).

We could add some scriptery to replace :latest with the current SHA, but not sure it's worth it.

@youngnick
Copy link
Member

When Rob cuts a 0.4.3 Gateway API release, we will get a versioned webhook, so I agree we should hold until then.

@skriss
Gateway API: update to v0.4.3, add validating webhook
a8cf888 
Updates the version of Gateway API to
v0.4.3 and adds the validating webhook
from that version to Contour's example
YAML files and E2E tests.

Closes projectcontour#3807.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss changed the title add Gateway API validating webhook Gateway API: update to v0.4.3, add validating webhook May 6, 2022
@skriss skriss removed the do not merge Don't merge this PR until this label is removed. label May 6, 2022
@skriss
Copy link
Member Author

skriss commented May 6, 2022

When Rob cuts a 0.4.3 Gateway API release, we will get a versioned webhook, so I agree we should hold until then.

This is now updated for Gateway API v0.4.3

@skriss skriss merged commit b06672c into projectcontour:main May 6, 2022
@skriss skriss deleted the gatewayapi-webhook branch May 9, 2022 15:02
skriss added a commit to skriss/contour that referenced this pull request May 9, 2022
@skriss
Gateway API: update to v0.4.3, add validating webhook (projectcontour…
bf86d78 
…#4489)

Updates the version of Gateway API to
v0.4.3 and adds the validating webhook
from that version to Contour's example
YAML files and E2E tests.

Closes projectcontour#3807.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this pull request May 9, 2022
@skriss
Gateway API: update to v0.4.3, add validating webhook (#4489)
ac2dfcf 
Updates the version of Gateway API to
v0.4.3 and adds the validating webhook
from that version to Contour's example
YAML files and E2E tests.

Closes #3807.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@youngnick youngnick Awaiting requested review from youngnick youngnick is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway API: add validating webhook to Contour install
3 participants
@skriss @youngnick @sunjayBhatia