Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e: Nil check before assertion on succeeded request #4080

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

sunjayBhatia
Copy link
Member

Log message uses status code from response which might be nil

Log message uses status code from response which might be nil

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner October 6, 2021 16:15
@sunjayBhatia sunjayBhatia requested review from tsaarni and stevesloka and removed request for a team October 6, 2021 16:15
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #4080 (a8342fd) into main (88d678b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4080   +/-   ##
=======================================
  Coverage   76.08%   76.08%           
=======================================
  Files         111      111           
  Lines        9099     9099           
=======================================
  Hits         6923     6923           
  Misses       2033     2033           
  Partials      143      143           

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had been meaning to get to this for awhile so thanks for taking care of it!

@stevesloka stevesloka merged commit ec04b41 into projectcontour:main Oct 6, 2021
@sunjayBhatia sunjayBhatia deleted the nil-check-response branch October 6, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants