internal/dag: Implement GatewayAllow for TLSRoutes #3735
Conversation
stevesloka
requested review from
danehans and
youngnick
and removed request for
a team
|
I'm going to follow up with some integration tests which would be nice to route through the API server properly. |
| @@ -707,7 +707,7 @@ func TestDAGInsertGatewayAPI(t *testing.T) { | |||
| }, | |||
| Spec: gatewayapi_v1alpha1.HTTPRouteSpec{ | |||
| Gateways: &gatewayapi_v1alpha1.RouteGateways{ | |||
| Allow: gatewayAllowTypePtr(gatewayapi_v1alpha1.GatewayAllowAll), | |||
| Allow: gatewayAllowTypePtr(gatewayapi_v1alpha1.GatewayAllowSameNamespace), | |||
There was a problem hiding this comment.
This was wrong previously and should have been "SameNamespace". The result is still correct, but just fixing up in this PR since it wasn't really testing the right thing.
There was a problem hiding this comment.
Also, I think we could DRY these tests up, there's a lot of duplication. 😢 But maybe a future thing.
Codecov Report
@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
- Coverage 75.72% 75.67% -0.06%
==========================================
Files 107 107
Lines 7297 7302 +5
==========================================
Hits 5526 5526
- Misses 1650 1654 +4
- Partials 121 122 +1
|
|
My logic is broken somewhere causing the TLSRoute to be kicked out. Digging into that now. |
stevesloka
force-pushed
the
gatewayallowTLSRoute
branch
from
560dd36
to
d5b1bb0
Compare
Fixes projectcontour#3695 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
gatewayallowTLSRoute
branch
from
d5b1bb0
to
88475bf
Compare
|
I didn't update the _integration tests, probably need fixes. Do we care at this point since we're trashing those? |
idk if the _integration removal will make it in before 1.16 so just to keep the pipeline green, maybe fix or remove the test assuming it is mirrored into e2e |
Signed-off-by: Steve Sloka <slokas@vmware.com>
Fixes #3695
Signed-off-by: Steve Sloka slokas@vmware.com