test/e2e: add HTTPProxy 007,018 and Ingress 001 tests #3665
Conversation
skriss
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3665 +/- ##
=======================================
Coverage 75.98% 75.98%
=======================================
Files 103 103
Lines 7130 7130
=======================================
Hits 5418 5418
Misses 1592 1592
Partials 120 120 |
skriss
force-pushed
the
e2e-certs
branch
2 times, most recently
from
922f477
to
c482277
Compare
skriss
requested review from
danehans and
sunjayBhatia
and removed request for
a team
| validClientCert := fx.Certs.GetTLSCertificate(namespace, "echo-client") | ||
| invalidClientCert := fx.Certs.GetTLSCertificate(namespace, "echo-client-invalid") | ||
|
|
||
| cases := map[string]struct { |
There was a problem hiding this comment.
all of the cert/fixture setup should match 1:1 with the original _integration test but I switched to using a matrix of test cases here to cover all the positive and negative cases. This should be a superset of what was being validated in the _integration version.
| "echo-with-auth-skip-verify without a client cert should succeed": { | ||
| host: authSkipVerifyProxy.Spec.VirtualHost.Fqdn, | ||
| clientCert: nil, | ||
| wantErr: "", | ||
| }, |
There was a problem hiding this comment.
@sunjayBhatia this is the case we were discussing.
There was a problem hiding this comment.
👍🏽 will update the other PR to cover this case
|
@sunjayBhatia ping for a review when you get a chance, thanks! |
Signed-off-by: Steve Kriss <krisss@vmware.com>
Updates projectcontour#3621. Signed-off-by: Steve Kriss <krisss@vmware.com>
Updates #3621.
Signed-off-by: Steve Kriss krisss@vmware.com