test/e2e: add Gateway API tests 001..005 #3630
Conversation
skriss
requested review from
sunjayBhatia and
youngnick
and removed request for
a team
| - path: test/e2e | ||
| linters: | ||
| - bodyclose |
There was a problem hiding this comment.
I kept getting a bunch of false positives from this linter so I just turned it off for test/e2e but can revisit and explicitly ignore each occurrence if folks aren't comfortably with this. I don't think it's a big deal since it's just test code so any negative impact of not closing HTTP response bodies is limited to CI.
Re-implements Gateway API tests 001..005 from _integration/testsuite/gatewayapi as Go tests. Updates projectcontour#3621. Signed-off-by: Steve Kriss <krisss@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #3630 +/- ##
=======================================
Coverage 76.78% 76.78%
=======================================
Files 100 100
Lines 7164 7165 +1
=======================================
+ Hits 5501 5502 +1
Misses 1542 1542
Partials 121 121
|
| // The HTTPRoute won't be fully valid, so just wait for it to have any Gateway | ||
| // status. | ||
| fx.CreateHTTPRouteAndWaitFor(route, func(route *gatewayv1alpha1.HTTPRoute) bool { | ||
| return len(route.Status.Gateways) > 0 |
There was a problem hiding this comment.
Now that we're doing this in go, do we want to check the actual status here to make sure the condition type etc. is correct?
There was a problem hiding this comment.
Yeah that makes sense, let me figure out what the status should be.
Signed-off-by: Steve Kriss <krisss@vmware.com>
|
Will need to add a test for tlsRoute which is added in #3627 (but not yet merged). Just wanted to track the change. =) |
|
@sunjayBhatia if you're OK with this as-is let's get it merged so we can continue moving fwd with migration. Follow-ups noted. |
Re-implements Gateway API tests 001..005 from
_integration/testsuite/gatewayapi as Go tests.
Updates #3621.
Signed-off-by: Steve Kriss krisss@vmware.com