Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/featuretests: Move xDS version v2 to v3 features tests #3124

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

stevesloka
Copy link
Member

Updates #1898

Signed-off-by: Steve Sloka slokas@vmware.com

Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka added this to the 1.11.0 milestone Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #3124 (9419e61) into main (a84d14d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3124   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files         117      117           
  Lines        7577     7578    +1     
=======================================
+ Hits         5777     5778    +1     
- Misses       1670     1671    +1     
+ Partials      130      129    -1     
Impacted Files Coverage Δ
internal/featuretests/v3/httpproxy.go 100.00% <ø> (ø)
internal/featuretests/v3/envoy.go 100.00% <100.00%> (ø)
internal/featuretests/v3/featuretests.go 90.10% <100.00%> (ø)
internal/xdscache/v3/listener.go 95.13% <100.00%> (+3.28%) ⬆️
internal/envoy/v2/tls.go 77.77% <0.00%> (-22.23%) ⬇️
internal/envoy/v2/cluster.go 82.92% <0.00%> (-17.08%) ⬇️
internal/xdscache/v2/cluster.go 87.87% <0.00%> (-12.13%) ⬇️
internal/envoy/v2/listener.go 86.24% <0.00%> (-10.79%) ⬇️
internal/xdscache/v2/secret.go 89.74% <0.00%> (-10.26%) ⬇️
internal/xdscache/v2/route.go 81.89% <0.00%> (-9.49%) ⬇️
... and 17 more

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM. I mainly checked for any remaining v2 refs (there were none) and visually scanned the rest.

Just confirming that we're ready to delete the v2 tests? I think it's fine as we're about ready to start deleting all the v2 code, but just double-checking.

@stevesloka
Copy link
Member Author

Just confirming that we're ready to delete the v2 tests?

Yup! Next we should be able to just drop all the v2 bits.

@stevesloka stevesloka merged commit e0fcb27 into projectcontour:main Nov 13, 2020
@stevesloka stevesloka deleted the moveFeatureTests branch November 13, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants